samkim-crypto

Nonce-reuse in symmetric encryption is a pretty strong security vulnerability, so generally, letting the wallet control the nonce entirely is a better option in my opinion. If a protocol that...

@CriesofCarrots @t-nelson, it would be great to get this PR merged before the migration 🙏 . Can you take one last look at the PR to check if the changes...

Yes, sorry it is my fault. A lot of the line changes are (un)doing refactors, so I can divide that part up.

Subsumed by https://github.com/solana-labs/solana/pull/33802, https://github.com/solana-labs/solana/pull/34678, and https://github.com/solana-labs/solana/pull/34989.

Yes, I think it makes more sense to add serialization in zk-token-sdk. We can eventually remove the ones in token-2022.

Yeah I now remember actually going through this same process for token-2022 also for Halborn. I dug out an old PR https://github.com/solana-labs/solana-program-library/pull/3588#issuecomment-1246341239. After looking over the repo, I think the...

Great, thanks for the catch! Will fix it in the next batch of updates.

Yes, the code has not yet been updated for the latest `zk-token-sdk`. This should be fixed in a day or two.

The errors should be fixed. In the future, as per the migration plan (https://github.com/solana-labs/spl-zk-token/issues/91), please refer to https://github.com/solana-labs/solana-program-library `solana-program-library/token/program-2022/` for the most up-to-date zk-token program.

I apologize for the late response on this. The wrong size for the confidential transfer mint and accounts in token-js will be fixed once https://github.com/solana-labs/solana-program-library/pull/6487 is merged. There has been...