Sami Jaber

Results 309 comments of Sami Jaber

This is definitely something we've considered doing. Maybe at some point in the future once Mitosis is more stable and there are more projects built with Mitosis!

This is the code that generates Mitosis component imports: https://github.com/BuilderIO/mitosis/blob/a3d65cad88d4a08460c09ef25cd7173d92093a21/packages/core/src/helpers/render-imports.ts#L154-L161 We actually have an `importMapper` here that can be passed as an option by generators, and is passed by the...

Yeah so, this is definitely a feature we've wanted to have in Mitosis! The only question is how to go about it. PS: This is not a simple feature! I'm...

An initial implementation for variable assignments is now merged: https://github.com/BuilderIO/mitosis/pull/1206

## Step 1 - store return type information We already do something similar here in another part of the parser: https://github.com/BuilderIO/mitosis/blob/9ec59b0f05e7abb46f82dd9532e2a75ae0a5a3de/packages/core/src/parsers/jsx/function-parser.ts#L182-L185 We will need to add similar logic for our...

The error is here: https://github.com/BuilderIO/mitosis/blob/8b4f9b7085af7457041333157a1cb1bf078a3b22/packages/core/src/parsers/jsx/element-parser.ts#L138-L142 We might need to change what we provide to `jsxtoElementJson`: I tried `jsxElementToJson(elseAttr.value)` but that caused other issues. 🤔

`useRef` is actually deprecated/non-existant in Qwik. We should be: - generating `useSignal` - accessing the values using `x.value` (adding `.value` suffix) https://qwik.builder.io/docs/components/state/#usesignal

@samuelOsborne I need some more information. Following the [bug issue format](https://github.com/BuilderIO/mitosis/issues/new/choose) helps because it requires a link to a mitosis.builder.io fiddle, which shows how to reproduce this issue reliably. here...

That's because this is the only way that the JSX syntax works: it has a `class` string prop that concatenates everything: [see example](https://mitosis.builder.io/?outputTab=G4VwpkA%3D&inputTab=FYZwHkA%3D&code=JYWwDg9gTgLgBAbzgVwM4FMDKNrrgXzgDMoIQ4AiAAQCNlgAbAE3SgDpgIB6EYHVYKgoBuAFCj0AD0iw4LIgENkDeEWQA7AMYxO6uAFkAngGEykdenUwAFGFJhUASkSi4cTRHWp43hTDwAvCgY2LjWSEQQmmgAXHAwUMh4%2BI5irnBQ6DDIUHrW6W4APMDqYMgwBW7uDAqoqAEIAAaRUCAAtCVl8AAkCHYQDmxMggo0DOhMcAD8lMOoo%2BNMFHBxFBSEvZVVcL7%2BbJHRqNOUB2jLqxRbBI34lVwAfOmpordAA%3D) You're right that for the Svelte syntax,...

Thanks for filing this bug. Here's where you'd want to add it: https://github.com/BuilderIO/mitosis/blob/8b4f9b7085af7457041333157a1cb1bf078a3b22/packages/core/src/generators/solid/index.ts#L173-L176 at the very start of the component, and rename the `props` object to something else like `initialProps`:...