Sami Jaber

Results 309 comments of Sami Jaber

This logic extracts the Provider from the original JSX and replaces it with a Fragment: https://github.com/BuilderIO/mitosis/blob/e862056eca675887bd975bf5696c61666d0f3532/packages/core/src/parsers/jsx/context.ts#L20-L47 The fix involves inlining the Provider's children into the array of the parent, instead...

This is great! You just need to update test snapshots with your latest test: ``` cd packages/core && yarn snapupdate ```

You also need to lint using `yarn fmt:prettier`

This is a bug. Here we generate these slots: https://github.com/BuilderIO/mitosis/blob/e862056eca675887bd975bf5696c61666d0f3532/packages/core/src/generators/vue/blocks.ts#L297-L305 We are missing the slots' properties and bindings, which are generated by this function: https://github.com/BuilderIO/mitosis/blob/e862056eca675887bd975bf5696c61666d0f3532/packages/core/src/generators/vue/blocks.ts#L378 I believe you should be...

Yes, I am describing the process of contributing a fix to Mitosis itself 😄

There might be a problem with the configuration of the repo. Do the tests pass if you run `yarn ci:build` in the root?

These definitions are stored in the `types` key, and the name of the type (`Props` in this case) is stored in `propsTypesRef`: https://github.com/BuilderIO/mitosis/blob/e862056eca675887bd975bf5696c61666d0f3532/packages/core/src/types/mitosis-component.ts#L148-L149 which is then consumed by each generator,...

If you are concerned about the `slot` prefix added to slots in React, that is being fixed right now in #1334

I just looked at the snapshot you screenshotted: https://github.com/BuilderIO/mitosis/blob/e862056eca675887bd975bf5696c61666d0f3532/packages/core/src/__tests__/data/blocks/content-slot-html.raw.tsx#L2-L8 It is actually an error to import the Mitosis `JSX.Element` here. For now, the best we can do is make this...

@Marvin-Brouwer I just re-read your implementation suggestion and realized it could cause breaking issues for other folks. Would you mind firing up a draft PR with what you have so...