Screenshot feature doesn't seem to work

[gradha]

Viewing a video I pressed Cmd+I which generated a png file on the desktop. The file is however empty despite being about 21kb in size. Maybe the image screen surface is not being copied and the png code saves a blank screen?

[samiamwork]

I think I know what this is. The capture code relies on some of the old OpenGL display path that's since been replaced but not totally removed (I don't remember why it's not totally removed yet). The code that actually does the capturing of the image is [MMovieView captureRect:] in MMovieView_Capture.m.

To fix this I'd either make the capture method handle the different display layer types or perhaps better, make the layers themselves dump out their contents (using a class extension for AVPlayerLayer).

Any interest in taking a stab at it?

[gradha]

Maybe in the future. Something else I've noticed is that the frames are captured from this OpenGL buffer (or something similar representing the window screen). The result is that frame capture has the same size as the displayed video. This is a bummer, I can't get a full hd screen capture on my laptop due to hardware limitations.

[samiamwork]

Interesting. It's probably been like that forever as a result of it getting the image by having it render out what's currently on screen. Using layer contents for this shouldn't have this problem.