slumber icon indicating copy to clipboard operation
slumber copied to clipboard

Published 20 hours ago • verified publisher icon samgiles

added logging to HTTP errors w/ url, status and response content

Open andymccurdy opened this issue 11 years ago • 5 comments

This change adds a "slumber" logger and uses it to emit ERROR level messages w/ the URL, HTTP Status and response content in the event of an HTTP error. This should make it easier to debug server errors on the client side.

andymccurdy avatar Aug 21 '13 19:08 andymccurdy

I believe this will also satisfy #68 and #17.

andymccurdy avatar Aug 21 '13 19:08 andymccurdy

Thanks for this! I’m not sure if error is the right level though; for production servers that could be too much logging. What about debug? /cc @hadrien @pior

merwok avatar Aug 21 '13 22:08 merwok

I'm fine using whatever log level you deem appropriate. Obviously an easy change. :)

andymccurdy avatar Aug 21 '13 22:08 andymccurdy

@merwok I agree with the error level. There is a "slumber" logger, so it's configurable.

pior avatar Aug 21 '13 22:08 pior

OK for the null handler.

@pior: are you saying you agree with the proposed error level?

merwok avatar Aug 21 '13 23:08 merwok