slumber icon indicating copy to clipboard operation
slumber copied to clipboard

slumber 0.5.1 returns empty string on successful POST

Open dekoza opened this issue 13 years ago • 7 comments

After successful POST slumber 0.5.1 (most recent in pypi) returns empty string instead of dict representation of newly created object.

This is a regression from 0.4.2

http://stackoverflow.com/questions/13777823/slumber-returns-empty-string-instead-of-object-data/

dekoza avatar Dec 08 '12 13:12 dekoza

bump. This breaks packages built on top (such as tastypie-queryset-client) and is related to #50.

stringfellow avatar Dec 19 '12 13:12 stringfellow

I propose this as desired behavior: if the response has a body with a content-type slumber can deserialize, parse and return it, else if there is a location header, return it, otherwise return None.

merwok avatar Mar 07 '13 04:03 merwok

That behavior sounds sane to me.

dstufft avatar Mar 07 '13 08:03 dstufft

Bump. This is still present in 0.6.0 and breaks packages built on top. Behavior proposed by merwok sounds OK.

dekoza avatar May 17 '13 12:05 dekoza

I’m available to review a patch/PR.

merwok avatar May 17 '13 18:05 merwok

Any news :-))) ?

stringfellow avatar Jul 31 '13 14:07 stringfellow

Patch welcome!

merwok avatar Jul 31 '13 15:07 merwok