Vaccine-Tracker-App
Vaccine-Tracker-App copied to clipboard
sameersrivastava13
Adding a Favicon
Description
As we know Favicon serves as branding for a website. Its main purpose is to help the visitors locate your page easier when they have multiple tabs open. So we need a logo/favicon for our website. The logo should be related to the topic of the project.
Have you read the Contributing Guidelines on Pull Requests?
Yes
Hey @Sejal2801, would like to work on making a logo! Could you assign me this
Ok @nagasaisriya Assigning it to you, Go ahead.
Thanks!
This is the logo design, feel free to suggest any edits:)
Looks good to me @nagasaisriya. What are your thoughts @Sejal2801 ?
Do one thing @nagasaisriya create a folder name Logo and place this image file in that folder in either .SVG or .PNG format and submit pull request.
@Sejal2801 Will keep this issue open for all. Later on will select the best logo out of the available for our application.
Looks good to me @nagasaisriya. What are your thoughts @Sejal2801 ? Do one thing @nagasaisriya create a folder name
Logoand place this image file in that folder in either .SVG or .PNG format and submit pull request.
Sure :)
Ya it's looking good😊
On Tue, 13 Jul, 2021, 7:43 PM nagasaisriya, @.***> wrote:
Looks good to me @nagasaisriya https://github.com/nagasaisriya. What are your thoughts @Sejal2801 https://github.com/Sejal2801 ? Do one thing @nagasaisriya https://github.com/nagasaisriya create a folder name Logo and place this image file in that folder in either .SVG or .PNG format and submit pull request.
Sure :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sameersrivastava13/Vaccine-Tracker-App/issues/33#issuecomment-879125334, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSYWCF6ZIPE3EDEA2DJOC3TXRCZFANCNFSM5AIU7AEQ .
@Sejal2801 Will keep this issue open for all. Later on will select the best logo out of the available for our application.
ya Sure
The issue is open for all. Anyone willing to design the logo can take this issue.
Added this since the size of a favicon is small and writing text in favicon doesn't make sense.
@sameersrivastava13 @Sejal2801 I had made few logo. Would like to have a look on them? Shall I send them here or through a PR request?
@sameersrivastava13 @Sejal2801 I had made few logo. Would like to have a look on them? Shall I send them here or through a PR request?
You can submit PR and show your designs there only. Also, Before submitting pr please fetch upstream.
@sameersrivastava13 @Sejal2801 Submitted the PR request.
Transparent Backgrounds are also submitted in the PR.
@Sayan-15 Please submit PR again with proper message. Here are the few options I had made for the logo.... size 100*100dp.
All these you can mention in the description. While submitting the PR give a meaningful title please. I merged your pr then reverted it back. Now you have to submit it again.
@sameersrivastava13 okay. As it was my first PR on GitHub, that's why the PR was not that much descriptive. I had submitted the PR again. Hope this time it would be much descriptive.
@sameersrivastava13 okay. As it was my first PR on GitHub, that's why the PR was not that much descriptive. I had submitted the PR again. Hope this time it would be much descriptive.
Already Merged @Sayan-15 . Good work.
Can I contribute for logo design @Sejal2801 @sameersrivastava13? Please assign me this issue .
