docker-gitlab icon indicating copy to clipboard operation
docker-gitlab copied to clipboard

GITLAB_PORT shows up in invitation emails link url

Open crud42 opened this issue 4 years ago • 4 comments
trafficstars

Hi! As i am currently in the process of updating some things :-) We just activated smtp and noticed that the GITLAB_PORT is visible in the generated URL inside the user invitation email:

https://gitlab.mydomain.com:10080/-/invites/YjxxcnrfNfws-sMBT6zrxxxxx

inside docker-compose.yml its properly configured:

gitlab:
  ports:
    - "10080:80" 

  environment:
    - GITLAB_PORT=10080

but it looks like the port is rendered into the link. I remember that also happend with some links inside gitlab, too.

Any why this is happening?

Many thanks and best, Chris

crud42 avatar Sep 01 '21 12:09 crud42

Short update: If i leave GITLAB_PORT blank ( "GITLAB_PORT=" ) everything works fine. However the provided docker-compose.yml states to use GITLAB_PORT=10080

crud42 avatar Sep 01 '21 13:09 crud42

Are you setting up a reverse proxy or something? I mean https://gitlab.mydomain.com/ is accessible?
If so, it is okay to leave GITLAB_PORT blank. GITLAB_PORT in docker-compose.yml of repository is just a example or typical use case.

kkimurak avatar Sep 18 '21 11:09 kkimurak

@kkimurak thats exactly the case. I figured that this might not be an example but the default setting.

Best

crud42 avatar Sep 23 '21 07:09 crud42

@crud42 hmm? from README.md and env-defaults that is loaded on startup, default value is 80 (or 443 if https is enabled) so I believe docker-compose.yml is an example.

Anyway, I'm glad your settings are works fine.

best,

kkimurak avatar Sep 23 '21 09:09 kkimurak