raco-pkg-env icon indicating copy to clipboard operation
raco-pkg-env copied to clipboard

Would be worth getting this built into raco

Open LeifAndersen opened this issue 3 years ago • 7 comments
trafficstars

This seems useful enough a command that it should probably be part of the standard distribution.

LeifAndersen avatar Aug 27 '22 00:08 LeifAndersen

@samth what do you think needs to happen to add this to the Racket standard distribution?

samdphillips avatar Aug 29 '22 03:08 samdphillips

Honestly not much. Take a look at raco pkg new:

https://github.com/racket/racket/blob/master/racket/collects/pkg/private/new.rkt

This does basically the same sort of thing.

So a little bit of documentation matching that would do the trick.

LeifAndersen avatar Aug 29 '22 04:08 LeifAndersen

For my own reference, the link to documentation scribble for pkg subcommands: https://github.com/racket/racket/blob/master/pkgs/racket-doc/pkg/scribblings/pkg.scrbl#L846

samdphillips avatar Aug 29 '22 04:08 samdphillips

How worried should I be about the "experimental" label? How thoroughly tested is this?

In general I definitely want to have this functionality available by default; just want to make sure we don't add it prematurely.

samth avatar Aug 29 '22 14:08 samth

FWIW I've been using it and its been fine. Two issues:

  1. Racket complains if you try to install a package that's already installed in a wider scope. Which is a limitation in Racket.
  2. Racket also complains if your current package scope is the same folder as a package you are trying to install. Which also is a limitation/bug with Racket.

I suspect by opening a PR in the main Racket repo there will be other people (cough @mflatt and @jeapostrophe cough) who will have other feedback.

LeifAndersen avatar Aug 29 '22 14:08 LeifAndersen

How worried should I be about the "experimental" label?

The label is mostly from my uncertainty about the mechanism the tool uses.

samdphillips avatar Aug 29 '22 15:08 samdphillips

I don't feel like it is that controversial... I think the README/docs don't have enough "why you should care"

jeapostrophe avatar Aug 30 '22 13:08 jeapostrophe