Sam Deane

Results 128 comments of Sam Deane

Yeah, makes sense. I'll leave it for now - as you say it makes more sense to tweak it when the feature is finished and you can be sure what...

> In which case could we add a has_binary_targets flag to Version after all Obviously that would then push some of the processing back to the analysis phase.

> Up-to-date instructions on logging queries are in https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/pull/1896. Cool - will take a look. > I'd rather keep the data and process it as we need it over having...

> so it may be worth checking the increase in that query cost before proceeding too much further So I've figured out how to turn on the query logging, but...

Is this related to the problem I found where re-analyse only touches some branches/versions? I think we discussed it @daveverwer, but I can't remember the exact details right now.

I think this is the relevant discussion: https://discord.com/channels/844491846452379649/844491937662763008/1001474049798586472

I found that I had to run `analyze` to get the main branch, and `re-analyze` to get the branches tagged with version numbers. Possibly you need a new mode for...

> Yes, that's definitely the case. Re-analyse only deals with existing versions while analyse captures new ones. Since analyse is running continuously, that should convert everything eventually. Will this not...

> I don't think a new mode is needed. The re-analyze doing old versions and regular-analyze doing default branches is fine. It's just not right that after several days the...

Just an update on my status - still happy to look at this, but quite tied up with some contracting (and a ton of other things) currently, so it might...