intellij-visual-studio-code-dark-plus icon indicating copy to clipboard operation
intellij-visual-studio-code-dark-plus copied to clipboard

The color scheme is not consistent with VS Code. import Purple/pink color is missing. JavaScript React JS

Open twilingway opened this issue 4 years ago • 6 comments

What the issue is?

if i set Keywords in WS function, const var let also change color

Screenshots

https://yadi.sk/i/Cpx2IfUBuJB9Og also component color wrong https://yadi.sk/i/JRqC2BxpHUlRjw

How would you fix it?

Additional info

Q A
Plugin Version 2.3
IDE and version 2020.1
Operating system win 10

twilingway avatar Mar 19 '21 20:03 twilingway

The problem is that PhpStorm puts all keywords in the same bag.

Here's a piece of code using VSCode, you can see conditions and return getting another highlight image

The same piece of code on PhpStop image

You can notice the isset having wrong color too (keyword for PhpStorm)

ArchLinux Java 11 PhpStorm 2020.3 Plugin v1.4

adrien-cuisse avatar Mar 21 '21 18:03 adrien-cuisse

Yeah. Can not fix it until PhpStorm will see these as different types.

samdark avatar Mar 21 '21 18:03 samdark

Perhaps it's a good idea to have a separate plugin for PhpStorm? Or Having at least import(s) and return(s) highlighted as purple/pink would be cool :). Thoughts?

dinbtechit avatar Jul 06 '21 16:07 dinbtechit

@dinbtechit well, extra tokenizing could theoretically be done in this plugin but I doubt I currently have enough time to implement it.

samdark avatar Jul 06 '21 18:07 samdark

@samdark - I have time to work on this but having a hard time wrapping my head around how tokenizing works. Can you give me a basic example of how to create tokenization in this plugin?

Like you said, class, implementation, etc and import are in the same bucket keyword. Which makes impossible to change just the import's color without affecting other keyword's color. Is it possible to create a "sub-bucket" under the keyword. Sadly, JetBrain's documentation is very limited on this.

image

dinbtechit avatar Aug 28 '21 23:08 dinbtechit

@dinbtechit I'm not aware of it :(

samdark avatar Aug 30 '21 07:08 samdark