Alexander Makarov comments

Results 1745 comments of


                                            Alexander Makarov

Add pcntl to (non-mandatory) requirements

Yes, I think it is a good idea to add it to requirements checker as optional dependency.

Add pcntl to (non-mandatory) requirements

Do you have some time for a pull request?

Supports PHPs DateTime instances

Yes, that is very convenient.

Create phar executable to use as global command

Would you please resolve conflicts?

Create phar executable to use as global command

Yes.

Replace `object` type for constraint name with `Stringable`

The reason it is like this now is that we've started DB for PHP 7.4 and `\Stringable` is available only since 8.0.

Extract common application parameters to separate file

I don't think it is needed. These look alright in `params.php`.

Extract common application parameters to separate file

Alright. Let's apply it then.

Add ability to set classes when resolving which an exception should be thrown

Could be done with: 1. Using annotations to mark each individual class. 2. Using annotations to mark parent interface. 3. Using a configuration to mark a namespace and its sub-namespaces.

Add ability to set classes when resolving which an exception should be thrown

Performance may drop because of these additional checks so: 1. Benchmark is needed. 2. If performace drop is significant, there should be an option to turn it off. It will...