Alexander Makarov comments

Results 1745 comments of


                                            Alexander Makarov

Support for PHP source directory

> put the PHP source in it's own directory You mean `src`? > I would go with either PSR-4 or PSR-0 It is already PSR-4: https://github.com/cebe/markdown/blob/master/composer.json#L30

Support for PHP source directory

That's for @cebe to decide but I support this move.

Consider support for Task lists in GFM

I don't think it's in the scope of the library itself. It should be possible to extend it to support it but that's too github-specific to implement.

Improve performance with leading backslash

I'm OK about it but in case it's automated. Having it as a manually checked rule would take too much time.

Environments

What's the purpose of caching them?

Chain calls must be put on separate lines

I usually do it as: ```php $object ->method1() ->method2(); ```

Chain calls must be put on separate lines

We may have it as a soft-rule with `should` instead of `must`.

Chain calls must be put on separate lines

Yes, it is.

Chain calls must be put on separate lines

@sankaest merged all PRs opened so far. Thanks!

Cycle ManyToMany relation is not working

@albertborsos how exactly does it fail? @roxblnfk would you please take a look?