Alexander Makarov comments

Results 1739 comments of


                                            Alexander Makarov

Undefined array key when moving to php8.1 with facets

Do you have some time for a pull request?

Add Attributes to inject scalar definitions & tags

Is `scalar` a concrete key there? Overall, that ties the code in question to this particular implementation of DI container. I'm not sure it is a great idea.

Add short array syntax

#48 seems to be better alternative.

Array Declaration must be short array syntax

I think that makes sense.

Allow abbreviated empty bodies.

While it looks a bit better, it is inconsistent i.e. adds more rules to follow making everything more complicated.

Allow abbreviated empty bodies.

Alright. With `MAY` it's OK.

Update on how to handle multi lines in control structures

I think we should close this PR. Thanks for participating anyway, @mathroc

Use readYAML instead of readJSON with Grunt (suggestion)

Cool trick. Thanks!

Provide a recipe for Google App Engine

Indeed, it would be great to get info about it. I haven't deployed Yii 2 to GAE so if you did, please share your experience.

Provide a recipe for Google App Engine

Well, examples of such files would be cool.