Alexander Makarov comments

Results 1736 comments of


                                            Alexander Makarov

Add comment property to database classes

https://github.com/yiisoft/yii2/pull/13162

Add method batchUpdate in \yii\db\QueryBuilder

Looks like a good idea. Further research on how to do it in MSSQL, Oracle and SQLite is needed to move forward to implementing it.

Query::one() should return null instead of false, when no results

I don't remember the reason why it was made like that initially and I think that fixing it in 2.0 may cause issues in existing apps. Should be fixed in...

count() method is returning string not integer

Hmm... yes. We can't do it :(

count() method is returning string not integer

32bit ints?

count() method is returning string not integer

But that's quite inconsistent. It's better to cast to string than to have two types. Developers will use `===` and will be quite surprised when the project DB would exceed...

count() method is returning string not integer

Actually what @rob006 proposes makes sense in practice. While under a 100 it may make sense to strictly compare counts, more than several thousands should always be done with `>`...

count() method is returning string not integer

Let's cast to `int` as @rob006 originally proposed. @yiisoft/core-developers objections?

[Refactoring todo] Master/Slave implementation of ConnectionInterface

Do you still want slave connection to be a pool of database connections? i.e. if there's multiple slave instances, would it still look like a single one to developer?

[Refactoring todo] Master/Slave implementation of ConnectionInterface

Decorator sounds great but the thing is that selecting master or slave depends on the query being made i.e. read queries go to slave, write queries go to master so...