Alexander Makarov comments

Results 1767 comments of


                                            Alexander Makarov

CI new pull request always fails?

I think it's a good idea to fall back to regular GitHub token if `YIISOFT_GITHUB_TOKEN` isn't available.

CI new pull request always fails?

No.

Bug - Declaration of Yii2::doRequest(object $request) must be compatible with Client::doRequest($request)

Do you have time for a pull request?

Bug - Declaration of Yii2::doRequest(object $request) must be compatible with Client::doRequest($request)

Fork repository first.

if [yii\filters\ContentNegotiator] is in `bootstrap` it does not work

I'd go way 1 since that's not touching framework itself. Do you have time for implementation?

Tests fail when database is used at application boostrap

> I'm not sure if using database during application bootstrap is even legal As you can see, that usage is tricky. > Another thing is – I'm not sure if...

[Feature] Per-unit and per-class fixture configuration - PR welcome?

Hm... I'd love fixtures that are specific for a test or use-case.

[Feature] Per-unit and per-class fixture configuration - PR welcome?

> So it could just be that he isn't acutely aware of all features... Yep. I'm still using legacy Codeception version in a few legacy projects. Had no chance to...

Fix file uploader, test typed attributes

Would you please add a line for CHANGELOG?

Fix file uploader, test typed attributes

:+1: