Alexander Makarov
Alexander Makarov
Can you fix tests to match new markup?
Hold on a bit. There's internal discussion aboit the change going on. Need some time.
I think it makes sense to fix it to actually accept page number and not offset-page number that is purely internal thing.
@yiisoft/core-developers what do you think?
@Offout we're talking purely about Yii 2.1.
As @klimov-paul pointed out, it could be adjusted at request level but I'm still thinking that defaulting to page number instead of offset makes sense.
Page number is used in yiisoft/data: https://github.com/yiisoft/data/?tab=readme-ov-file#offset-pagination
Won't add it in 2.0 since it's feature-locked. Will consider for 3.0.
That's not about data source. It's about UI such as the one in GMail:
I don't think there's any reason for it.