Alexander Makarov comments

Results 1745 comments of


                                            Alexander Makarov

Implement the methods `getAllAssignments()`, `getAllRoles`, `getAllRules()` in `Manager::class`

It's good to have these but it won't work for real-world cases: 1. If there are too many assignments (and that is very likely) pagination is needed. 2. For a...

Implement the methods `getAllAssignments()`, `getAllRoles`, `getAllRules()` in `Manager::class`

I think it's a good idea to release without these and then add it in a subsequent major release.

Throw exception when loading data from file failed

That's checking if path is a file, not that it failed loading. On loading failure, an exception would be thrown. The reason for current code is for the file to...

What's the purpose to support null value in startsWith?

Originally it was made so parameter could be checked for it without checking for null.

What's the purpose to support null value in startsWith?

Could be adjusted in the next major version.

Add option to use different type of cache (Redis, etc.)

What's the benefit?

Add option to use different type of cache (Redis, etc.)

OK.

Named arguments vs immutable methods

Creating an object is quite cheap but the syntax change is to the worse in my opinion.

Named arguments vs immutable methods

Need to measure these in order to make a decision about if it makes sense to change routing syntax.

There is a bug here

@beowulfenator would you please take a look?