Alexander Makarov comments

Results 1745 comments of


                                            Alexander Makarov

AR refresh() with relations

Yes. Looks like so.

Ignore unnecessary joinWiths

How do you want to fix it? Joining the same table is fine. For example, if you need N levels of adjacent list at the same time.

Ignore unnecessary joinWiths

Yes. That may work.

ActiveRecord unlink() not applying events/behaviors on junction model - inconsistent with link()

Moved.

Faulty caching in AR relations with via and callable

https://github.com/yiisoft/yii2/pull/11107

Active Record 'OR' query

Sounds reasonable.

AR beforeSave attributes

Changing it in 2.0 would break current behavior. Moving to 2.1.

ActiveRecord::__get priority

1. That's OK. 2. Doesn't sound right. If you have the same name, it's conflicting anyway so it doesn't really matter what's preferred. It's not right anyway.

ActiveRecord::__get priority

I mean change you've proposed is OK.

Static relations

1. Breaking BC is OK if there are pros and no other cons. 2. I don't like that `getCustomers()` and `->customers` are currently different. That isn't explicit. 3. Ability to...