Alexander Makarov comments

Results 1745 comments of


                                            Alexander Makarov

Getters and setters for Activerecord

Sounds like a good idea to me. Any idea on how to implement that?

Getters and setters for Activerecord

OK. Let's have a pull request (can you make it?) and see what unit tests will show us. Also I'm a bit concerned about performance since method_exists is reflection.

Getters and setters for Activerecord

getters+setters list, I think. AR can't be ORM because query language will rely on field names anyway.

Getters and setters for Activerecord

I mean that mapping won't change what you use in `->andWhere(['field_name' => 42])` so I prefer a mapping for getters and setters only.

Getters and setters for Activerecord

I'm against adding a flag. Benchmarks would be great though.

Getters and setters for Activerecord

See https://github.com/yiisoft/yii2/pull/16496

\yii\db\BaseActiveRecord::save() returns false if \PDOStatement::rowCount() is falsy after insert

Could be done in 2.1.

\yii\db\BaseActiveRecord::save() returns false if \PDOStatement::rowCount() is falsy after insert

I see no reason for that if PDO driver is implemented correctly.

Magic getter in BaseActiveRecord has readability and extensibility issues

Here's my variant of it with comments. A bit more performant and maybe a bit more readable: ```php public function __get($name) { // if there's a value for such attribute,...

Magic getter in BaseActiveRecord has readability and extensibility issues

Overall, it's not a critical thing to hold release. Moving to next milestone.