samcrane8
update header and logo
- Changed default logo to GT logo within App.vue
- Changed color of header within App.vue
Is there any way you could make it so that the config file tells you which file you should use for the logo as well as the color? I still want to make this repository agnostic to the specific campus that uses the code, i.e. if another school uses this codebase they shouldn't have to use the GT logo.
Yea I was thinking about that right before I did the pull request. I know we need to keep the repo design details open to everyone. I just did the pull request so that you saw that I completed the task :)
From: Sam Crane [email protected] Sent: Saturday, June 8, 2019 12:07:28 PM To: samcrane8/FlyRight Cc: Christopher Campbell; Author Subject: Re: [samcrane8/FlyRight] update header and logo (#15)
Is there any way you could make it so that the config file tells you which file you should use for the logo as well as the color? I still want to make this repository agnostic to the specific campus that uses the code, i.e. if another school uses this codebase they shouldn't have to use the GT logo.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/samcrane8/FlyRight/pull/15?email_source=notifications&email_token=ACL2VGKZ7KPONP7CRY6XHQDPZPKMBA5CNFSM4HWHEQSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHXP5Y#issuecomment-500135927, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACL2VGIKE5JPIIW36WDHWETPZPKMBANCNFSM4HWHEQSA.
okay cool. in the meantime can you modify this pull request to allow for the dynamic branding? Look elsewhere in the codebase on how to use the config file.