Feature suggestions

[kidonng]

Hi there! This is definitely one of the most useful gh extensions right now, and it compliments gh very well. I don't think we need to implement the whole GitHub into it (not to mention it's impossible), but some improvements over the current state would be awesome:

• [x] Press Esc (and maybe also q) to quit

  Currently it seems only Ctrl+C exits which is not intuitive.

• [ ] Line numbers

• [ ] Breadcrumb (e.g. path/to/file)

[samcoe]

@kidonng Thanks for writing in. These are good ideas. Some of my thoughts on them:

• Definitely agree that exiting on Esc makes sense. I would hold off on q though since the behavior would be inconsistent with which pane is in focus. Pressing q while searching for a file name should definitely not exit.

• Line numbers would be great to have but a challenge to add. I investigated this a bit and would likely require major changes to the textview widget in rivo/tview.

• Can you expand on the breadcrumbs idea a bit more? Would it just be a way to view the full file path at the top of the code viewing pane?

[mTvare6]

What about e for open in $EDITOR