Sam Claus comments

Results 21 comments of


                                            Sam Claus

release wasm + asm.js version on npm

Hi, what is the status on this? Is there anyway to compile this to a WebAssembly target that can be lazy-loaded to a page? I have heard Rust has excellent...

Allow indicating component "root" element so actions may be used on the component tag

> If this is added, we could use style-directives on components. Yes, and any of the other directives you can apply to normal elements, including actions. That does make me...

Clean up DOM event listeners when destroying Map's animation proxy

@Falke-Design May I simply add a `this.off()` call to the `Map.remove()` method? I believe the map is already unusable after removal, so that simply removing all event listeners in a...

Clean up DOM event listeners when destroying Map's animation proxy

@Falke-Design I made the following changes: 1. The `Map` constructor originally had the following: ```js // zoom transitions run with the same duration for all layers, so if one of...

Clean up DOM event listeners when destroying Map's animation proxy

@jonkoops Pinging because it has been almost 3 months. Can this fix be merged?

Help should be provided for the map container keyboard shortcuts [accessibility]

Something to consider is the scope of the library, as well as end-user JavaScript bundle size because that typically suffers when adding features. To me, the value that Leaflet provides...

feature: support multiple case matching in `ngSwitch`/`@switch`

Just to offer some framework cross pollination: Svelte does not currently have a `{#switch}` directive. However, it does have full-fledged `if-else-if-else-if-...-else` logic support in templates. By comparison, Angular's over-engineered `*ngIf`...

feature: support multiple case matching in `ngSwitch`/`@switch`

@petebacondarwin That's awesome! Sounds like you guys have a good game plan. Of course it will take time. I don't think any serious developers would shame a team for taking...

Fix: save & restore state for nested encode & decode calls

@danielgavrilov I'm glad the library has been of use to you and thank you for taking the time to make this PR and even write a test case. I regret...

use ._parts instead of _rings to get tooltip center location on screen

As someone who has spent a great deal of time refactoring my own fork of Leaflet, this idea seems like a very sensible improvement. TBH I gutted the tooltip code...