SCEditor icon indicating copy to clipboard operation
SCEditor copied to clipboard

#Fixes 545 Replaced <p> with div for body content.

Open TwinFuture opened this issue 7 years ago • 1 comments

As stated in issue replaced the tags that get inserted into the document on load and when creating a new line. This solves the issue of quotes splitting and removing

that would get replaced with

so just use div instead as default for content lines.

Issue #545 Issue #540

TwinFuture avatar Dec 15 '16 23:12 TwinFuture

Thanks for the PR! This fixes the issue for BBCode but not for XHTML output which could have <p> tags pasted or added in the source. Also it's currently possible to insert HTML into the BBCode editor or tags that convert to <p> which this wouldn't fix.

As <div> tags seem to work slightly better it might be worth converting all <p> tags into divs with a special class in setWysiwygEditorValue. The BBCode plugin works fine with divs and the XHTML plugin can convert them to paragraphs. Will need some testing to verify that works OK but should fix all the issues if it does.

If you want to test that and make a PR that'd be great but don't worry if not I can always do it.

samclarke avatar Dec 18 '16 12:12 samclarke