Sam Snyder
Sam Snyder
I think it could be appropriate in rewrite-maven-plugin to check some of the common SSL-skipping parameters used in Maven builds and provide an appropriate http client in the execution context
It seems like the recipes included in this PR are possible already without introducing new public API surface area in the form of this `Namespaces` concept. If this PR were...
What's the motivation here? Does this solve a problem you are running into?
It isn't clear to me that we need to make this extensible. We're happy to add to the list of extensions for each parser. Do you have a file extension...
I would rather add an entry to the hardcoded list than add an entire extension mechanism. If all you need is to parse Karaf's configuration files as properties we can...
I took a look at this. The example test cases misunderstand the purpose/necessity of the `objectIdentifyingProperty` parameter of this recipe. When merging into a sequence the recipe has to have...
It's not _exactly_ what you were asking about in this issue, but [this fix](https://github.com/openrewrite/rewrite/commit/159f27c215be4efe82d5b6ddf7c6ccf27d0d3e6e) may also be relevant. The test case I added is somewhat similar to what you have...
That feels like a reasonable improvement to make, I will look into it
If the recipe moves the strangely-placed annotations in-place that is fine, this recipe's purpose will have been accomplished. If the recipe moves the annotation to the usual/canonical place for annotations...
For such a large project it'll generally work better to separate parsing and recipe execution into separate steps. That is how our commercial saas product works - build plugin produces...