lo icon indicating copy to clipboard operation
lo copied to clipboard

REQUEST: Allow Compact() to accept any type.

Open FGasper opened this issue 7 months ago • 2 comments

If the is-empty determination uses reflect.ValueOf(&x).Elem().IsZero() then that function can usefully work on any type, not just comparables.

FGasper avatar Aug 19 '25 13:08 FGasper

Hey, I was going through this issue and it looks interesting.
I’m new to contributing here, but I’d like to give it a try if it makes sense to add.

intojhanurag avatar Aug 23 '25 10:08 intojhanurag

It’s super simple; they already have an is-zero check via reflect elsewhere in the same file.On Aug 23, 2025, at 06:36, Anurag Ojha @.***> wrote:intojhanurag left a comment (samber/lo#660) Hey, I was going through this issue and it looks interesting. I’m new to contributing here, but I’d like to give it a try if it makes sense to add.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

FGasper avatar Aug 23 '25 13:08 FGasper