lo icon indicating copy to clipboard operation
lo copied to clipboard

go-funk included when vendoring due to usage in benchmark

Open jondot opened this issue 2 years ago • 2 comments

Hi, Moving from go-funk to lo, just noticed go-funk is still included in my dependency graph, probably due to it being a dependency for the benchmark suite in lo. Not sure, but is there any way to remove it from the 'release' lib?

jondot avatar Mar 20 '22 09:03 jondot

~~Have you tried go mod tidy?~~

wirekang avatar Apr 21 '22 15:04 wirekang

Many libraries are added: testify (+ dependencies), go-funk (+ dependencies)...

I agree with you, we should distribute a clean release of this library.

I think the best way to achieve it, is to move test files into a dedicated module.

samber avatar Apr 22 '22 17:04 samber

Hey guys. Just checked on this and I don't see any test dependecies in vendored packages (probably due to module graph pruning introduced in 1.17 https://go.dev/ref/mod#graph-pruning)

image

sergeykonkin avatar Nov 18 '22 22:11 sergeykonkin

Did you check go.sum ?

samber avatar Nov 20 '22 17:11 samber

Yeah, my bad. go.sum contains all deps:

image

sergeykonkin avatar Nov 21 '22 08:11 sergeykonkin