sam bacha

Results 228 comments of sam bacha

Can this issue be closed @mattsse

> Compared to comments, using modifiers for test granularity has two downsides: > > > > 1. Much more difficult to make breaking changes (imagine your code not compiling after...

We should differentiate between user requested links and crawled -- each link has to be intentionally added through a service like https://perma.cc Additionally an allowlist of acceptable providers should be...

> I was specifically suggesting that a copy be kept in the assets folder. Sites like archive.org and perma.cc are still susceptible to being taken down. perma.cc provides a png...

> @poojaranjan brought up a great point. A lot of EIPs die in the draft stage, so the first pull request is the only point editors have to influence these...

> I don't understand the attack vector here. You sign a permit on a local fork with a different chainId and that gets out? here is the thread, sorry! https://twitter.com/bantg/status/1560279527976161282

> wow, that chain is already cursed 😬 😂 it’s whatever you think ser, I can submit a PR if you would take it, I thought it best to see...

> Yeah, let's do it. So have been thinking about this over the weekend, wdyt about a helper function to re-sign a message with a spending limit 0 to nullify...

> Why not just call `increaseNonce()`? 🪡

> > Reentrancy as a language feature is built for the 5-10% of professionals that understand the underlying implications > > My personal view on that (which is not OZ...