dockerclient icon indicating copy to clipboard operation
dockerclient copied to clipboard

Docker PullImage API is broken

Open diptanu opened this issue 10 years ago • 3 comments

After the PR around better error message was merged into master, the PullImage API seems to be broken.

I am getting the following error message -

invalid character '{' after top-level value

when I am downloading an image from a private repository, for example - myregistry/busybox

My fork which was created before the PR #49 was merged works as expected - https://github.com/diptanu/dockerclient

@donhcd @vieux @samalba

diptanu avatar Jan 14 '15 14:01 diptanu

you're right - I assumed that the JSON objects would be newline-separated but that's unfortunately not true. I'm working on a PR to fix this

donhcd avatar Jan 15 '15 06:01 donhcd

@diptanu please take a look and see if this works for you ^ Parsing all of the json objects is pretty negligible compared to the network io, so I don't think there's anything wrong with me doing that.

donhcd avatar Jan 15 '15 19:01 donhcd

I merged #66 because it fixed the issue for me.

@diptanu please confirm

vieux avatar Jan 17 '15 02:01 vieux