Samuel Roldan comments

Results 49 comments of


                                            Samuel Roldan

Change Request: Provide a way for rules to apply suggestions to other files

Per 2024-04-04 TSC meeting, we've decided to table the discussion until we have time to review it more thoroughly.

Change Request: Consider also moving slightly-more-than-formatting rules out of core

Per 2024-04-04 TSC meeting, we've decided to deprecate these two rules and coordinate with `eslint-stylistic` to incorporate and maintain them going forward.

Rule Change: allow `void` in `array-callback-return` for `Array.prototype.forEach`

Hey @nopeless, I am not too familiar with this lint rule and I'm trying to repro in the [playground](https://eslint.org/play/#eyJ0ZXh0IjoiLyplc2xpbnQgYXJyYXktY2FsbGJhY2stcmV0dXJuOiBcImVycm9yXCIqL1xuXG52YXIgaW5kZXhNYXAgPSBteUFycmF5LnJlZHVjZShmdW5jdGlvbihtZW1vLCBpdGVtLCBpbmRleCkge1xuICAgIG1lbW9baXRlbV0gPSBpbmRleDtcbn0sIHt9KTtcblxudmFyIGZvbyA9IEFycmF5LmZyb20obm9kZXMsIGZ1bmN0aW9uKG5vZGUpIHtcbiAgICBpZiAobm9kZS50YWdOYW1lID09PSBcIkRJVlwiKSB7XG4gICAgICAgIHJldHVybiB0cnVlO1xuICAgIH1cbn0pO1xuXG52YXIgYmFyID0gZm9vLmZpbHRlcihmdW5jdGlvbih4KSB7XG4gICAgaWYgKHgpIHtcbiAgICAgICAgcmV0dXJuIHRydWU7XG4gICAgfSBlbHNlIHtcbiAgICAgICAgcmV0dXJuO1xuICAgIH1cbn0pO1xuXG5cblxuLy8gZXhhbXBsZSBvZiBhIG5vbi12b2lkIHNpZGUtZWZmZWN0IGZ1bmN0aW9uXG5bMSwyLDNdLmZvckVhY2gobiA9PiBjbHMuY29tcHV0ZUNhY2hlKG4pKVxuXG4vLyB3aWxsIHN1Z2dlc3QgdGhlIGZvbGxvd2luZ1xuLy8gSW5zZXJ0IHZvaWRcblsxLDIsM10uZm9yRWFjaChuID0+IHZvaWQgY2xzLmNvbXB1dGVDYWNoZShuKSlcblxuLy8gV3JhcCBpbiB7fVxuWzEsMiwzXS5mb3JFYWNoKG4gPT4ge2Nscy5jb21wdXRlQ2FjaGUobil9KVxuIiwib3B0aW9ucyI6eyJwYXJzZXJPcHRpb25zIjp7ImVjbWFWZXJzaW9uIjoibGF0ZXN0Iiwic291cmNlVHlwZSI6Im1vZHVsZSIsImVjbWFGZWF0dXJlcyI6e319LCJydWxlcyI6eyJhcnJheS1jYWxsYmFjay1yZXR1cm4iOlsiZXJyb3IiXX0sImVudiI6eyJlczYiOnRydWV9fX0=) but do not see it marking any of the examples you've...

Rule Change: allow `void` in `array-callback-return` for `Array.prototype.forEach`

@nopeless will you be able to create a separate PR?

Update WeekCalendar.md

It would be nice to merge this PR as the provider is really important to understand how to use this component.

Doesn't work with Neovim

Same. Decided to just turn this pluging off. :/

feat: `no-restricted-imports` option added `allowImportNames`

We've decided in the 2023-03-23 TSC meeting to hold off on merging the PR. Notes from this meeting will be published in this [PR](https://github.com/eslint/tsc-meetings/pull/419/files).

Chromatic Action bug: `skip` doesn't always mark "UI Review" as skipped

Chromatic support point me to this issue. For anyone wondering, this is how to pass the env vars to it: ```yaml name: Chromatic on: pull_request: types: [opened, synchronize, labeled, unlabeled]...

Change Request: Introduce a system to suppress existing errors

Should there be a RFC for this proposal?

Rule Change: [no-extra-parens] assume unknown node types need to be parenthesised if they are parenthesised

Considering that `const z = (2).toFixed();` is perfectly okay and it passes; I think this is a good rule change. You got my `+1`. 👍