Sam Johnson

Results 213 comments of Sam Johnson

@kirbyfan64 taking your idea into account, adding `--link-flags "-lcrypto -lz"` made it compile successfully

So to bring everyone up to speed, it looks like the OpenSSL pkg-config needs to be updated so that `-lcrypto` always goes before `-lz`. Looking at the code I don't...

Would it instead be desirable to make the existing `construct_runtime!` macro be the production one and do a `construct_dev_runtime!` that can be opted into? Otherwise I feel like this is...

Note that after a while I realized that the suggested syntax: ```rust #[frame_support::pallet] #[frame_support::pallet::dev_mode] pub mod pallet { ``` will not work because the `pallet::` macros are only valid _inside_...

I agree that this is a good place to use a builder pattern and I really like the syntax. One key requirement when doing something like this is to make...

Once the nits and merge conflicts are resolved and CI is passing looks good at least to me :)

Note that we are resizing to the same size here just as a toy example. In reality we are usually downsizing a bit. Resizing to the same size should be...

Totally understand, let me clarify. The problem isn't that metadata isn't being preserved, it's that the compression image-rs is producing for animated gifs is dramatically worse than the compression exhibited...

I'll poke around the code and see what I can figure out. For my purposes it sounds like the best approach might be to do k-means clustering on all the...

Oh looks like gifski might do what I want!! https://github.com/ImageOptim/gifski