Sam Johnson

Results 173 comments of Sam Johnson

I have fixed the merge conflicts with the recent POV work (#11637) and ensured that that is carried over properly in the `v1` module. Waiting on a fix on master...

> So this is a non-breaking change, right? Maybe mention that explicitly in the description so downstream teams can (for now) mostly ignore it. Yup will do!

just pushed my re-write of this using my macro_magic crate (now working on the `examples/basic` example). Here is debug output from the basic example, tests on basic pass: ``` foreign_path:...

So dealing with a very weird issue here if anyone has any input In master this code in the authorship pallet (and similar code in several other pallets) compiles fine:...

> But what about this: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=9fe9e04140fd0316ab4dff307f9de8e7 I don't see any problem with this @bkchr curious what @kianenigma thinks. Alternatively we could instead just add this in a follow-up PR 🤔

With the latest push (and after much difficulty) this now actually works with the recent syn 2.x upgrade, and I ended up having to re-write most of the new config...