Sam Adams comments

Results 28 comments of


                                            Sam Adams

🐛 Bug: Parallel mode crashes if test exception contains circular references

This PR hopefully help with the second case (which is something we were seeing when developing with nestjs): https://github.com/mochajs/mocha/pull/5032

🚀 Feature: Test Sharding for CI Matrix Purposes

@amerryma did you make any progress?

🚀 Feature: Test Sharding for CI Matrix Purposes

@amerryma i think it's worth creating the PR at this point.

fix: better tracking of seen objects in error serialization

Worth a re-run of the failing test?

fix: better tracking of seen objects in error serialization

@Uzlopak looks like it might be a false positive. Windows tests ok for v14/v18 and i can't think of anything that might be low-level enough to affect just that set...

Question: Update enum column types in knex migration

This issue is still helping people (me) all this time later 🤣 In case it helps anyone else further, i had to adapt @Jordan24's example like so in typescript (also...

DefaultCredentialsProvider not using maxAttempts configuration

Just had the same issue with `"@aws-sdk/client-sqs": "^3.245.0"` (thanks to @RanVaknin for the code to manually setup the node provider - worked a treat!). For more context: we are using...

Provide a way to prevent `getKeysInterceptor` falling back to `jwksUri` when the result doesn't contain the `kid`

fwiw i think option 3 is the best: > 3. make jwksUri OR getKeysInterceptor be required (rather than jwksUri being required). If jwksUri is not set, don't fall back.

Provide a way to prevent `getKeysInterceptor` falling back to `jwksUri` when the result doesn't contain the `kid`

I put this PR up just because i had already done it the `jwksUriFallback` boolean way for my specific case: https://github.com/auth0/node-jwks-rsa/pull/389 but happy to change to whataever

feat: add a '.toIncludeSamePartialMembers()' custom matcher

I was just coming to this repo to start on this feature - nice one!