Sam McCall

Results 207 comments of Sam McCall

As I just mentioned on the code review, I think this design is very complicated for the value it provides. I don't see evidence that there's widespread need for a...

compile_commands.json gets scanned for changes when we reparse a file, but we don't currently reparse opened files when their commands change. Maybe we should...

Can you try `-query-driver=/usr/bin/avr-g++`? This will attempt to extract them, unfortunately it's off by default for security reasons.

@kadircet Is this check still needed? Standalone clang-include-cleaner doesn't have it, so I suspect the new include-cleaner lib is robust enough to handle system includes (at least for the people...

You can take a look at https://github.com/clangd/chrome-remote-index/blob/main/docs/index.md This avoids the need to build and load (most of) the index locally.

The `Deprecated` label still seems semantically appropriate to me, given that the user has explicitly opted into wanting to modernize such uses - these checks are all off by default....

Sorry, I keep losing my comment... I think we should get this in front of HLSL clang devs ASAP, and in front of "regular" users as soon as there's been...

Those headers lack include guards, so clangd will never attempt to insert or remove them. Clangd attempts to manage only "well-behaved" headers: those that are intended to be included directly,...

This is true, clangd treats symlinks as multiple names for the same file and generally asks the OS to canonicalize. Without canonicalizing filenames, we don't know which of several symlinked...

A few thoughts from a maintainer of the clangd extension (also @kadircet), though the publishing was set up before my time... - As Christian said, the publicly-visible thing is the...