Sam Roberts

Results 130 comments of Sam Roberts

If we actually have to install node on a ci machine, that's pretty much a non-starter, IMO. On the other hand, if the node binary is so damaged it can't...

@mhdawson You said that it might be allowed to have a GPL project under nodejs/, we just have to ask the foundation. Can you do that, or tell me how...

@MylesBorins I was a bit puzzled by the above comment, because its exactly what we do currently, then I realized the original description used the phrase "node dependency", and I...

> I had misunderstood when I quickly reviewed the repo thinking that tap13.py was a vendored dependency, not the part of the repo itself. :+1: > From a quick review...

@cclauss found @rajcze --- Josef, see conversation above, are you willing or able to relicense https://github.com/nodejs/tap2junit/blob/master/tap2junit/tap13.py from GPL? I understand licensing is your choice, so absolutely no hard feelings if...

https://ci-release.nodejs.org/job/iojs+release/5882/ Re-enabled, running master CI, :crossed_fingers:

I'd like to see this change as well, having security vulns in the default use case isn't something that should be enouraged for express users (or any project). @replacepreg this...

https://github.com/expressjs/generator/pull/236 is passing, except on node too old to understand `const`.

I prefer the __declspec(export) over .def file, on most projects, the windows .def file drifts out of sync with the code.