Salvatore Campagna

Results 30 comments of Salvatore Campagna

This will be enough just to have a counter for documents so that we can efficiently count the ratio of documents having the `_ignored` field and not for counting bytes...

I need to re-run the tests above since they have errors. `search_by_doc_id` runs fine while `get` and `mget` fail, which is a bit surprising. I need to verify that assertions...

Attaching test results [params-8-13-tsdb-low-latency-best-compression.json](https://github.com/elastic/elasticsearch/files/15374915/params-8-13-tsdb-low-latency-best-compression.json) [params-8-13-tsdb-low-latency-best-speed.json](https://github.com/elastic/elasticsearch/files/15374916/params-8-13-tsdb-low-latency-best-speed.json) [params-8-14-tsdb-low-latency-best-compression.json](https://github.com/elastic/elasticsearch/files/15374917/params-8-14-tsdb-low-latency-best-compression.json) [params-8-14-tsdb-low-latency-best-speed.json](https://github.com/elastic/elasticsearch/files/15374918/params-8-14-tsdb-low-latency-best-speed.json) [tsdb-low-latency-best_compression-8-13-vs-best_compression-8-14.txt](https://github.com/elastic/elasticsearch/files/15374920/tsdb-low-latency-best_compression-8-13-vs-best_compression-8-14.txt) [tsdb-low-latency-best_speed-8-13-vs-best_speed-8-14.txt](https://github.com/elastic/elasticsearch/files/15374921/tsdb-low-latency-best_speed-8-13-vs-best_speed-8-14.txt)

Comparing the best compression option using Elasticsearch 8.13 and Elasticsearch 8.14 we can see results that seems a bit contradicting, with some GET queries being faster in 8.14 and other...

I thin Nhat is correct...I can spot the pattern "AAAAA" at the beginning of the id which means that a buffer including only 0-value bytes has been Base64 encoded. So...

Having a look at this before starting to work on it and complete what is (maybe) missing. My understanding is that in future we would like to enable synthetic source...

@javanna @felixbarny I am pushing a commit which makes the field 'stored' again because I would like to see if that makes the CI green. My understanding is that metadata...

Almost there...after making the field stored (and including doc values) I see all tests green but the following one: https://gradle-enterprise.elastic.co/s/aqxgf3itnzdvc/tests/:server:test/org.elasticsearch.index.mapper.IgnoredFieldMapperTests/testFetchIgnoredFieldValue I need to have a look at the fetch phase...

> @salvatore-campagna you need to switch the field to b retrieved from doc_values instead of from stored fields. That is controlled by the `valueFetcher` method in the mapped field type...

Based on my investigation and after talking to @javanna fetching metadata fields is, at the moment expected to happen in `StoredFieldPhase` as a result of the field being stored, which...