nextron icon indicating copy to clipboard operation
nextron copied to clipboard

Simplest way to upgrade existing nextron?

Open armenr opened this issue 5 years ago • 6 comments

Hey there! Thank you for all of your incredible and wonderful work.

My team loves me for having implemented Nextron into our repo. In turn, I remind and tell them about the fact that it's the maintainers of Nextron they should be loving :)

We do have a question, however:

What is the most straightforward way to update/upgrade our nextron implementation? :)

Thank you!

armenr avatar May 09 '19 08:05 armenr

@saltyshiomix - any potential advice? :)

armenr avatar May 15 '19 12:05 armenr

Hi, @armenr !

Thank you for your testing nextron and your question!

Sorry I have no any ideas for now, because nextron is an app generator. But I think it's so wonderful if it can check for updates and show diffs to patch like Git.

Anyway, I'll investigate the implementation this month 👍

saltyshiomix avatar May 15 '19 13:05 saltyshiomix

How about making nextron a module like create-react-app, electron-webpack or preact-cli ? It will make upgrades easier.

create-nextron-app and nextron can be like create-react-app and react-scripts.

The helpers functions can be bundled into nextron/helpers or something, like next/link.

hadeeb avatar Jun 07 '19 11:06 hadeeb

First of all, thanks for the well structured code. It was really easy going through it.

I have a working draft here. Please have a look at it.

  • No more path rewriting.
  • Can use next/link and <a> tags.
  • No more full page reloads on page transition (SPA like behaviour).
  • Made dev and build commands part of nextron package, so that they can be updated independently.
  • Moved next,react & react-dom to devDependencies -> dmg size reduced by ~9MB.

TODO

  • Option to extend/modify webpack config.
  • Port remaining examples.

If this is something you want to pursue, I am more than happy to help.

hadeeb avatar Jun 07 '19 20:06 hadeeb

@hadeeb

Thank you for your lots of advices in advance :)

https://github.com/saltyshiomix/nextron/issues/30#issuecomment-499854160

Here is create-nextron-app already.

https://github.com/saltyshiomix/nextron/issues/30#issuecomment-500030425

If you have some time, could you create a PR? WIP-PR is also welcome :)

I'm so sorry for replying late and not working forward in this issue.

saltyshiomix avatar Jun 09 '19 11:06 saltyshiomix

@armenr / @hadeeb

Nextron v5 is out! (with Next.js v9)

$ npm install -g nextron@latest

Any advices are welcome 👍

saltyshiomix avatar Jul 12 '19 04:07 saltyshiomix

I'm closing this issue since it's been inactive for so long, as well as cleared since then. Have a good day !

Psycokwet avatar May 07 '23 13:05 Psycokwet