nextron icon indicating copy to clipboard operation
nextron copied to clipboard

Get background file from `main` in `package.json`

Open Richienb opened this issue 2 years ago • 3 comments

~~Why detect the tsconfig.json file when you can just detect the file that is going to be compiled in the first place?~~ Get the background file from the main property in the package.json file.

Currently I am using an empty tsconfig.json file to use background.ts without a tsconfig.json file.

Richienb avatar Aug 27 '21 05:08 Richienb

@Richienb Can you please explain me what problem this PR solves ? I want to test your pr and if solves or improves something then merge it.

andirsun avatar Aug 29 '22 04:08 andirsun

I want to use TypeScript without needing to create an empty tsconfig.json file.

Richienb avatar Aug 29 '22 05:08 Richienb

I am going to test this PR tomorrow and see how it goes

andirsun avatar Aug 29 '22 06:08 andirsun

Is it relevant to keep this PR open? I dont think so.

alexis-piquet avatar Mar 13 '23 02:03 alexis-piquet

I don't think the problem is solved yet

Richienb avatar Mar 13 '23 03:03 Richienb

2 years for a PR its a very long one, this is the reason why I've added a comment previously. ;)

If the issue isn't resolved yet, could you fix conflicts? Without that I can't approve it.

alexis-piquet avatar Mar 13 '23 10:03 alexis-piquet

@alexis-piquet please fix the remaining conflict to approve.

andirsun avatar Apr 03 '23 15:04 andirsun

Looks like something went wrong with the branch, it's not pushed in the repo properly and I cant fetch it. @Richienb Could you fix conflicts or push it properly? 😘

alexis-piquet avatar May 04 '23 08:05 alexis-piquet

ok

Richienb avatar May 04 '23 08:05 Richienb

Lets merge to see how it goes and then we can iterate or revert if needed.

andirsun avatar May 04 '23 20:05 andirsun