salt icon indicating copy to clipboard operation
salt copied to clipboard

[3006.x][TECH-DEBT] Fix Package integration tests for MacOS and Ubuntu Arm64

Open dmurphy18 opened this issue 1 year ago • 1 comments

Description Package integration tests are failing for MacOS and Ubuntu Arm64 based machines, this is a place holder issue that these need to be fixed, as they are disabled for now to allow testing of PR's to proceed.

Setup Nightly Builds or any test:full PR

Please be as specific as possible and give set-up details.

  • [ ] on-prem machine
  • [ ] VM (Virtualbox, KVM, etc. please specify)
  • [ ] VM running on a cloud service, please be explicit and add details
  • [ ] container (Kubernetes, Docker, containerd, etc. please specify)
  • [ ] or a combination, please be explicit
  • [ ] jails if it is FreeBSD
  • [ ] classic packaging
  • [X] onedir packaging
  • [ ] used bootstrap to install

dmurphy18 avatar Jun 26 '24 20:06 dmurphy18

Package Integration Files to fix in directory tests/pytests/pkg/integration:

  • test_enabled_disabled.py
  • test_salt_call.py
  • test_salt_exec.py
  • test_salt_grains.py
  • test_salt_key.py
  • test_salt_output.py
  • test_salt_state_file.py
  • test_version.py
  • test_salt_api.py

dmurphy18 avatar Jun 27 '24 15:06 dmurphy18

Note PR https://github.com/saltstack/salt/pull/66763 has fixes for package tests (still under testing), where pytest-skip-markers just released v1.5.2 has fix for MacOS Arm64 based systems, such that, is_aarch64 is now correct when run on MacOS Arm64 systems, see https://github.com/saltstack/pytest-skip-markers/pull/36

dmurphy18 avatar Aug 09 '24 21:08 dmurphy18

Closing since PR https://github.com/saltstack/salt/pull/66806 is merged

dmurphy18 avatar Aug 16 '24 15:08 dmurphy18