salt
salt copied to clipboard
[3006.x] fixes #66252 correct use of egrep to parse semanage output
What does this PR do?
What issues does this PR fix or reference?
Fixes: #66252
Previous Behavior
Attempting to run selinux.fcontext_policy_present with a filecontext which is a shorter version of one which is already defined would fail with
File context for ... is not defined
New Behavior
The state will now apply correctly
Merge requirements satisfied?
- [ ] Docs
- [X] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
- [X] Tests written/updated
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
looks okay, but need s to pass pre-commit
@dmurphy18 looks to me like the failure was down to a blank line on the end of the test.
I've removed that now
@ndptech Have you done 'pre-commit install', I believe you have not, otherwise that blank line would have been caught when you attempted 'git commit'. Recommend you do the 'pre-commit install' to prevent lint errors etc in the future.
@dmurphy18 I'd missed that part of the contributing docs. It's done now and one more minor formatting correction is in place
@ndptech Need to address failing tests before review
@dmurphy18 Is there anything else I need to do here or has the change that @twangboy added resolved the CI issues?
Congratulations on your first PR being merged! :tada:
This has introduced failing tests, see https://github.com/saltstack/salt/actions/runs/11499408739/job/32010027668 for example
@lkubb Have fix in https://github.com/saltstack/salt/pull/66986, awaiting review and merge