salt icon indicating copy to clipboard operation
salt copied to clipboard

[master] Fix file.is_link hangs on paths that are hung mounts

Open nicholasmhughes opened this issue 1 year ago • 2 comments

What does this PR do?

See issue for details.

What issues does this PR fix or reference?

Fixes: #66096

Previous Behavior

It was possible for the file.is_link function to hang if the target was on a hung mount.

New Behavior

The nostat parameter handles link checking in a way that won't hang in those circumstances.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

  • [x] Docs
  • [x] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
  • [x] Tests written/updated

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

nicholasmhughes avatar Feb 19 '24 13:02 nicholasmhughes

Thanks for up-streaming this 👍

Kickball avatar Feb 19 '24 13:02 Kickball

LGTM - thanks for the changes!

Kickball avatar Mar 07 '24 19:03 Kickball