salt icon indicating copy to clipboard operation
salt copied to clipboard

[master] Handle pkg version for apk

Open the-nando opened this issue 1 year ago • 3 comments

What does this PR do?

This PR implements version handling for packages installed via the apk module.

What issues does this PR fix or reference?

Fixes: https://github.com/saltstack/salt/issues/66053

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

  • [x] Docs
  • [ ] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
  • [ ] Tests written/updated

Commits signed with GPG?

Yes

the-nando avatar Feb 13 '24 10:02 the-nando

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

welcome[bot] avatar Feb 13 '24 10:02 welcome[bot]

@s0undt3ch as far as can I see there are no tests at all for apk pkg and setting them up from scratch isn't a simple task I'm afraid. I can leave this open as is for someone to add tests or close it, whichever you prefer.

the-nando avatar Feb 14 '24 07:02 the-nando

@s0undt3ch as far as can I see there are no tests at all for apk pkg and setting them up from scratch isn't a simple task I'm afraid. I can leave this open as is for someone to add tests or close it, whichever you prefer.

I'm not asking for full test coverage of the apk module, of course, and yes, there should already exist some test coverage for it, but sadly, there's not.

I'm basically asking for a regression test for the change you did, a unit test which validates installing a package with and without a version.

If you don't feel up for it, we'll leave it open for a while in case someone wants to pick it up.

There really is no bandwidth from the core team right now to add these.

s0undt3ch avatar Feb 14 '24 08:02 s0undt3ch