salt icon indicating copy to clipboard operation
salt copied to clipboard

[TECH DEBT] Replace pycurl/tornado with requests in salt.utils.http

Open dwoz opened this issue 1 year ago • 3 comments

Having pycurl as a dependency for making web requests behind a proxy causes issues under our onedir packaging approach. Pycurl has no plans of releasing wheels meaning users will have to compile against libcurl. We have plans to migrate away from tornado anyway so it makes sense to replace pycurl and tornado with the python requests library.

dwoz avatar May 26 '23 20:05 dwoz

See also #64299 and #62949

dwoz avatar May 26 '23 20:05 dwoz

if this is implemented do a piece of news about it in good time, we have built proxy-minion tools using the "native" solution that would require a lot of rebuilding if implemented

Zpell82 avatar Jun 07 '23 13:06 Zpell82

if this is implemented do a piece of news about it in good time, we have built proxy-minion tools using the "native" solution that would require a lot of rebuilding if implemented

Can you explain more. If the proxy functionality in salt.utils.http works the same as it did before, why will that break things for you?

dwoz avatar Jun 14 '23 19:06 dwoz

My understanding is that proxy support is now fully working again (as of 3006.8) the last issue as fixed by #66163.

dwoz avatar Jun 18 '24 03:06 dwoz