salt icon indicating copy to clipboard operation
salt copied to clipboard

#Issue63469 Update documentation to include performance impact warnings and workaround

Open shashwatpandeyvns opened this issue 2 years ago • 9 comments

What does this PR do?

What issues does this PR fix or reference?

Fixes: https://github.com/saltstack/salt/issues/63469

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

  • [x] Docs
  • [ ] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
  • [ ] Tests written/updated

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

shashwatpandeyvns avatar Feb 02 '23 15:02 shashwatpandeyvns

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

welcome[bot] avatar Feb 02 '23 15:02 welcome[bot]

@shashwatpandeyvns Could you update communication guide page as well?

rawmind avatar Feb 03 '23 15:02 rawmind

@shashwatpandeyvns Could you update communication guide page as well?

@rawmind I believe the update for the communication guide "https://github.com/saltstack/salt-get-started/pull/36" has been merged to the master file successfully. BTW how do I check if this is merged or not? All thanks to you for helping me.

shashwatpandeyvns avatar Feb 03 '23 19:02 shashwatpandeyvns

@rawmind In this one few workflows failed and a review is required as well, is there any issue with the code?

shashwatpandeyvns avatar Feb 03 '23 19:02 shashwatpandeyvns

@shashwatpandeyvns thank you for the PR. As I said I'm not a part of salt team. You should wait until someone from the team make review and approve it. Unfortunately, I can't assist you to resolve GH pipelines issues.

rawmind avatar Feb 03 '23 22:02 rawmind

@shashwatpandeyvns, thanks so much for being so responsive and making those changes. I will have some time on Monday to take another look at this PR and so I'll definitely review your changes in more depth at that time. Thanks again for your help!

barbaricyawps avatar Feb 09 '23 17:02 barbaricyawps

@shashwatpandeyvns , I'm just circling back on this PR. Did you have a chance to respond to @Ch3LL 's question about your warning note?

barbaricyawps avatar Jun 20 '23 19:06 barbaricyawps

pre-commit is failing here. and it looks ot be related to this change.

Ch3LL avatar Aug 24 '23 18:08 Ch3LL

Bump ^

Ch3LL avatar Oct 18 '23 19:10 Ch3LL