salt icon indicating copy to clipboard operation
salt copied to clipboard

rest_tornado hangs indefinitely when minions do not return

Open mspi92 opened this issue 2 years ago • 1 comments

In the following line https://github.com/saltstack/salt/blob/245991ab2ca812d02c317dbe5b52d5d0442c50ee/salt/netapi/rest_tornado/saltnado.py#L1027 The code of: minions = set( self.ckminions.check_minions(chunk["tgt"], chunk.get("tgt_type", "glob")) )

needs to be changed to: minions = set( self.ckminions.check_minions(chunk["tgt"], chunk.get("tgt_type", "glob"))["minions"] )

This yields the real list of minions, otherwise the list of entries will be the keys of the dictionary, which are "minions", "missing", "ssh_minions" etc.

Because of the way how the code of _disbatch_local method is designed these false entries in combination with a really existing non returning minion leave the _disbatch_local method in an infinite waiting loop.

mspi92 avatar Aug 10 '22 09:08 mspi92

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

welcome[bot] avatar Aug 10 '22 09:08 welcome[bot]

Please provide the output of salt --versions, details of any master/minion differences, a reproduction case, and anything else from the bug report template that is relevant.

OrangeDog avatar Aug 10 '22 15:08 OrangeDog