salt icon indicating copy to clipboard operation
salt copied to clipboard

fix #61369 kubeadm init & join

Open daro1337 opened this issue 2 years ago • 4 comments

What does this PR do?

What issues does this PR fix or reference?

Fixes: #61369

Previous Behavior

Unable to create k8s (v1.23.X) cluster via salt module

New Behavior

I can create k8s cluster (v1.23.X) via salt module

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

  • [X] Docs
  • [ ] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
  • [X] Tests written/updated

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

daro1337 avatar Aug 10 '22 07:08 daro1337

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

welcome[bot] avatar Aug 10 '22 07:08 welcome[bot]

So, only problem i have with this change is that experimental should not just be dropped off of the command. as it should be deprecated. give users a hey this is going to stop working two versions from now, use this instead. and then change to the non experimental internally.

whytewolf avatar Sep 14 '22 21:09 whytewolf

@daro1337 did you see my note above?

whytewolf avatar Sep 19 '22 19:09 whytewolf

@whytewolf Sorry, I was a bit busy. I will try to add a fix with your suggestion

daro1337 avatar Sep 20 '22 07:09 daro1337

@whytewolf

I fixed it according to your suggestions. Instead of removing the old argument, I added support for the new one with the appropriate description about the kubeadm version.

daro1337 avatar Sep 25 '22 18:09 daro1337

alright. so it does need a changelog.

whytewolf avatar Oct 05 '22 16:10 whytewolf

@daro1337 can we get a changelog on this and I"ll approve after that.

whytewolf avatar Oct 27 '22 16:10 whytewolf

@whytewolf done

daro1337 avatar Oct 27 '22 18:10 daro1337

Congratulations on your first PR being merged! :tada:

welcome[bot] avatar Oct 28 '22 00:10 welcome[bot]