salt
salt copied to clipboard
fix #61369 kubeadm init & join
What does this PR do?
What issues does this PR fix or reference?
Fixes: #61369
Previous Behavior
Unable to create k8s (v1.23.X) cluster via salt module
New Behavior
I can create k8s cluster (v1.23.X) via salt module
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
- [X] Docs
- [ ] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
- [X] Tests written/updated
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. Please be sure to review our Code of Conduct. Also, check out some of our community resources including:
- Community Wiki
- Salt’s Contributor Guide
- Join our Community Slack
- IRC on LiberaChat
- Salt Project YouTube channel
- Salt Project Twitch channel
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!
So, only problem i have with this change is that experimental should not just be dropped off of the command. as it should be deprecated. give users a hey this is going to stop working two versions from now, use this instead. and then change to the non experimental internally.
@daro1337 did you see my note above?
@whytewolf Sorry, I was a bit busy. I will try to add a fix with your suggestion
@whytewolf
I fixed it according to your suggestions. Instead of removing the old argument, I added support for the new one with the appropriate description about the kubeadm version.
alright. so it does need a changelog.
@daro1337 can we get a changelog on this and I"ll approve after that.
@whytewolf done
Congratulations on your first PR being merged! :tada: