salt icon indicating copy to clipboard operation
salt copied to clipboard

chore(ci): add informational Codecov status checks

Open thomasrockhu-codecov opened this issue 3 years ago • 2 comments
trafficstars

What does this PR do?

Hi, Tom from Codecov here. I noticed that you were using Codecov but weren't actually getting any notifications on pull requests. I figured it would be useful to get some idea if code being changed is being tested, but also not blocking CI/merging.

I know there's been a lot of changes on this file previously with statuses, and I just want to make sure if this is not the right solution, what might be useful in getting feedback from Codecov.

Let me know if this makes sense or if we can do something that would be helpful.

What issues does this PR fix or reference?

N/A

New Behavior

Add non-blocking status checks from Codecov

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

  • [ ] Docs
  • [ ] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
  • [ ] Tests written/updated

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

thomasrockhu-codecov avatar Apr 18 '22 14:04 thomasrockhu-codecov

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

welcome[bot] avatar Apr 18 '22 14:04 welcome[bot]

bump @garethgreenaway

thomasrockhu-codecov avatar Aug 04 '22 20:08 thomasrockhu-codecov

Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle.

dwoz avatar Dec 10 '23 23:12 dwoz