salt icon indicating copy to clipboard operation
salt copied to clipboard
verified publisher icon saltstack

avoids crash on cache corruption

Open cmcmarrow opened this issue 4 years ago • 4 comments

What does this PR do?

Avoids crash on cache corruption

What issues does this PR fix or reference?

Fixes: https://github.com/saltstack/salt/issues/60170

Previous Behavior

Hard crash

New Behavior

Error is logged at error level

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

  • [ ] Docs
  • [ ] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
  • [ ] Tests written/updated

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

cmcmarrow avatar Dec 13 '21 02:12 cmcmarrow

https://github.com/saltstack/salt/issues/33544

cmcmarrow avatar Dec 13 '21 03:12 cmcmarrow

bump @cmcmarrow did you see my review?

Ch3LL avatar Dec 21 '21 17:12 Ch3LL

Theres some test failures that need to be cleaned up

Ch3LL avatar Mar 03 '22 21:03 Ch3LL

@cmcmarrow are you able to come back to this PR and fix the tests?

Ch3LL avatar Aug 31 '22 19:08 Ch3LL

@waynew can you re-review this please

Ch3LL avatar Oct 10 '22 20:10 Ch3LL