Document behavior when fileserver_followsymlinks is False.
When fileserver_followsymlinks is set to False, keep_symlinks and force_symlinks are not taken in account because symlinks are not even seen by the file server. See #29562.
What does this PR do?
Adds documentation about the default behavior of a couple of options for the file.recurse state.
What issues does this PR fix or reference?
Fixes: 29562 (partially)
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. Please be sure to review our Code of Conduct. Also, check out some of our community resources including:
- Community Wiki
- Salt’s Contributor Guide
- Join our Community Slack
- IRC on LiberaChat
- Salt Project YouTube channel
- Salt Project Twitch channel
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!
Maybe I should mention that's the default behavior?
I have no idea what to do about https://github.com/saltstack/salt/pull/61285/checks?check_run_id=4298450074
Hi! I'm your friendly PR bot!
You might be wondering what I'm doing commenting here on your PR.
Yes, as a matter of fact, I am...
I'm just here to help us improve the documentation. I can't respond to questions or anything, but what I can do, I do well!
Okay... so what do you do?
I detect modules that are missing docstrings or "CLI Example" on existing docstrings! When I was created we had a lot of these. The documentation for these modules need some love and attention to make Salt better for our users.
So what does that have to do with my PR?
I noticed that in this PR there are some files changed that have some of these issues. So I'm leaving this comment to let you know your options.
Okay, what are they?
Well, my favorite, is that since you were making changes here I'm hoping that you would be the most familiar with this module and be able to add some other examples or fix any of the reported issues.
If I can, then what?
Well, you can either add them to this PR or add them to another PR. Either way is fine!
Well... what if I can't, or don't want to?
That's also fine! We appreciate all contributions to the Salt Project. If you can't add those other examples, either because you're too busy, or unfamiliar, or you just aren't interested, we still appreciate the contributions that you've made already.
Whatever approach you decide to take, just drop a comment here letting us know!
Detected Issues (click me)
[INFO] Initializing environment for https://github.com/saltstack/pip-tools-compile-impersonate. [INFO] Initializing environment for https://github.com/asottile/pyupgrade. [INFO] Initializing environment for https://github.com/saltstack/pre-commit-remove-import-headers. [INFO] Initializing environment for https://github.com/s0undt3ch/salt-rewrite. [INFO] Initializing environment for https://github.com/timothycrosley/isort. [INFO] Initializing environment for https://github.com/timothycrosley/isort:toml. [INFO] Initializing environment for https://github.com/psf/black. [INFO] Initializing environment for https://github.com/asottile/blacken-docs. [INFO] Initializing environment for https://github.com/asottile/blacken-docs:black==21.7b0. [INFO] Initializing environment for https://github.com/PyCQA/bandit. [INFO] Initializing environment for https://github.com/saltstack/invoke-pre-commit. [INFO] Initializing environment for https://github.com/saltstack/invoke-pre-commit:blessings,distro,jinja2,msgpack,pyyaml. [INFO] Initializing environment for https://github.com/saltstack/mirrors-nox. [INFO] Initializing environment for https://github.com/saltstack/mirrors-nox:pip>=20.2.4,
Thanks again!
@StyXman Can you fix the lint and pre-commit errors. other wise the information looks good.
Congratulations on your first PR being merged! :tada: