salt icon indicating copy to clipboard operation
salt copied to clipboard

Add Kafka event return support

Open zmingee opened this issue 4 years ago • 3 comments

What does this PR do?

Add event return support to Kafka returner module.

Also added a test module and refactored the module.

Previous Behavior

Event returns were not supported by the Kafka returner module.

New Behavior

Event returns are now supported by the Kafka returner module.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

  • [Y] Docs
  • [N] Changelog - https://docs.saltstack.com/en/master/topics/development/changelog.html
  • [Y] Tests written/updated

Commits signed with GPG?

Yes

zmingee avatar Apr 19 '21 21:04 zmingee

@zmingee could you move the test under tests/pytests/unit/returners and create changelog entry?

krionbsd avatar Apr 20 '21 06:04 krionbsd

@krionbsd I've moved the test module and added the changelog entry as requested.

zmingee avatar Apr 20 '21 15:04 zmingee

@zmingee There seems to be some problems with this PR, some items are being pulled in from other PRs from the last time you pulled in from master. and there are conflicts. Can you please correct these issues.

whytewolf avatar Sep 21 '22 16:09 whytewolf

Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle.

dwoz avatar Dec 10 '23 11:12 dwoz